-
Notifications
You must be signed in to change notification settings - Fork 75
695: New method for managing THP #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
=========================================
Coverage 73.44% 73.44%
=========================================
Files 18 6 -12
Lines 2802 934 -1868
Branches 429 143 -286
=========================================
- Hits 2058 686 -1372
+ Misses 630 210 -420
+ Partials 114 38 -76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think we still need to support disabling transparent huge pages for MongoDB 7.0. |
Yes, that's still in place. The role should create the appropriate systemd service, to enable or disable thp, according to the value of mongodb_enable_thp. |
Oops yep, I glanced at this and thought it was replacing the existing service. My bad! |
|
||
[Service] | ||
Type=oneshot | ||
ExecStart=/usr/bin/env sh -c "echo 'always' > /sys/kernel/mm/transparent_hugepage/enabled && echo 'always' > /sys/kernel/mm/transparent_hugepage/defrag" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this was intentional, but this unit is quite different from the example provided in the MongoDB docs.
SUMMARY
New method for managing THP. MongoDB 8 comes with a recommendation to turn thp on now.
TODO:
ISSUE TYPE
COMPONENT NAME
mongodb_linux