Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm: Add force flag #8885

Merged
merged 5 commits into from
Sep 21, 2024
Merged

npm: Add force flag #8885

merged 5 commits into from
Sep 21, 2024
+19 −2

Conversation

abakanovskii
Copy link
Contributor

SUMMARY

Add --force flag for nmp module
Fixes #8678

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nmp

ADDITIONAL INFORMATION

It seemed easy to implement without breaking backward compatibility

# Now this is possible
- name: Force Install "coffee-script" node.js package.
  community.general.npm:
    name: coffee-script
    force: true

@ansibullbot
Copy link
Collaborator

cc @shane-walker @xcambar
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module plugins plugin (any type) labels Sep 20, 2024
@russoz russoz changed the title Add force flag for nmp module npm: Add force flag Sep 20, 2024
russoz
russoz reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abakanovskii , thanks for the contribution!!

There's a couple of adjustments needed, but other than that it looks good to me.

plugins/modules/npm.py Show resolved Hide resolved
changelogs/fragments/8885-add-force-flag-for-nmp.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Sep 20, 2024
russoz
russoz approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 21, 2024
@felixfontein felixfontein merged commit 38479ee into ansible-collections:main Sep 21, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 21, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/38479ee9ff7060f497f4d99b661beca38e4e1693/pr-8885

Backported as #8893

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 21, 2024
@abakanovskii @patchback
npm: Add force flag (#8885)
9395a09 
* Add force flag for nmp module

* Add CHANGELOG fragment

* Add force to cmdrunner

* Update CHANGELOG

* Add comma

(cherry picked from commit 38479ee)
@patchback patchback bot mentioned this pull request Sep 21, 2024
Merged
@felixfontein
Copy link
Collaborator

@abakanovskii thanks for your contribution!
@russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Sep 21, 2024
@patchback @abakanovskii
[PR #8885/38479ee9 backport][stable-9] npm: Add force flag (#8893)
eae0c4f 
npm: Add force flag (#8885)

* Add force flag for nmp module

* Add CHANGELOG fragment

* Add force to cmdrunner

* Update CHANGELOG

* Add comma

(cherry picked from commit 38479ee)

Co-authored-by: alexander <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch feature This issue/PR relates to a feature request module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to run npm install --force
4 participants
@abakanovskii @ansibullbot @felixfontein @russoz