redfish_utils: Let @Redfish.OperationApplyTime be optional #8824
Conversation
As the doc states, this is not a required option. AMI BMC will complain since it's not supported. So don't add this option unless it's explicitly specified by update_apply_time. Signed-off-by: Chih-Wei Huang <[email protected]>
|
@cwhuang This PR contains |
ansibullbot
added
bug
AMI BMC requires a separate OemParameters json to set the image type when doing MultipartHTTPPushUpdate. The patch adds a new option update_image_type to support it. Test OK with AMI BMC 13.3. Signed-off-by: Chih-Wei Huang <[email protected]>
| @@ -1899,6 +1900,9 @@ def multipath_http_push_update(self, update_opts): | |||
| 'UpdateParameters': {'content': json.dumps(payload), 'mime_type': 'application/json'}, | |||
| 'UpdateFile': {'filename': image_file, 'content': image_payload, 'mime_type': 'application/octet-stream'} | |||
| } | |||
| if image_type: | |||
There was a problem hiding this comment.
There is no "image type" defined in the Redfish Specification. This looks like a very specific OEM definition for the OEM multipart form.
Would it be possible to make this more generic to accommodate other OEM usage? There's no predefined data type (it could be XML, JSON, binary, plain text...), and the form name isn't specifically "OemParameters".
Please check out Table 40 — Multipart HTTP push updates in the Redfish Spec here: https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.20.2.pdf
There was a problem hiding this comment.
Actually the pull request should only contain the first commit.
It just removes the default value set for @Redfish.OperationApplyTime.
The second commit is for another feature request I created in issue #8825
I planned to send it in another pull request. But seems github combined them
automatically probably because I put them in the same branch.
Sorry for the confusion since I'm not familiar enough with the process.
Let me know how to do it correctly.
There was a problem hiding this comment.
You can do git revert <COMMITHASH> to back out your changes from a given commit.
You then should make a new branch and cherry-pick that commit over.
felixfontein
added
check-before-release
|
Thanks for your contribution! Please note that you need to add a changelog fragment. Thanks. |
felixfontein
removed
the
backport-8
|
@cwhuang ping needs_info |
ansibullbot
added
the
needs_info
felixfontein
removed
the
backport-9
|
@cwhuang This pullrequest is waiting for your response. Please respond or the pullrequest will be closed. |
As the doc states, this is not a required option. AMI BMC will complain since it's not supported. So don't add this option unless it's explicitly specified by update_apply_time.
SUMMARY
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/redfish_utils.py
ADDITIONAL INFORMATION