copr: add includepkgs functionality #8779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
|
@ansibullbot ready_for_review |
ansibullbot
removed
ci_verified
|
Thank you for the contribution! Please add a changelog fragment. I will be taking a closer look throughout the day. |
|
thanks for reply @russoz |
|
Perhaps also excludepkgs for completeness? |
russoz
reviewed
Aug 20, 2024
russoz
reviewed
Aug 20, 2024
russoz
reviewed
Aug 20, 2024
russoz
changed the title
felixfontein
added
check-before-release
Hi @shubhamsugara22 not sure you noticed this comment from @ossman . It does make sense to have both, IMO. Would you be willing to add that one here as well? It should be fairly easy now that you're more familiar with it. 😉 |
russoz
approved these changes
Aug 21, 2024
|
LGTM! :-) Thanks @shubhamsugara22 !! |
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8808 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Added changes in copr module * Excludepkgs parameter add * Update module and params to handle a list + Docs updated * Update module and params to handle a list + Docs updated (cherry picked from commit 96d5e6e)
|
@shubhamsugara22 thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Aug 27, 2024
…ality (#8808) copr: add includepkgs functionality (#8779) * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Added changes in copr module * Excludepkgs parameter add * Update module and params to handle a list + Docs updated * Update module and params to handle a list + Docs updated (cherry picked from commit 96d5e6e) Co-authored-by: Shubham Singh Sugara <[email protected]>
aioue
pushed a commit
to aioue/community.general
that referenced
this pull request
Oct 1, 2024
* Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Added changes in copr module * Excludepkgs parameter add * Update module and params to handle a list + Docs updated * Update module and params to handle a list + Docs updated
TobiasZeuch181
pushed a commit
to TobiasZeuch181/zypper_repository_add_list
that referenced
this pull request
Oct 2, 2024
* Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Limit package for Copr using includepkgs * Added changes in copr module * Excludepkgs parameter add * Update module and params to handle a list + Docs updated * Update module and params to handle a list + Docs updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A new includepkgs parameter has been added to the copr module, allowing users to specify which packages to fetch from a COPR repository. This enhancement addresses the issue where users only want to install specific packages without inadvertently pulling in other packages from the repository. The includepkgs option is added to the repository configuration and persists across Ansible runs, ensuring that the repository remains consistent with the user’s desired package selection.
Fixes
#8738
ISSUE TYPE
COMPONENT NAME
copr
ADDITIONAL INFORMATION
The new includepkgs parameter allows users to limit the scope of packages fetched from a COPR repository. This feature is particularly useful for users who need to manage their package installations tightly and avoid any unexpected changes from updates to the repository. The implementation includes appending the includepkgs option to the repository file and ensuring that it is not overwritten by subsequent Ansible runs.