Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab_project - add missing parameters #8768

Closed
wants to merge 2 commits into from
Closed

gitlab_project - add missing parameters #8768

wants to merge 2 commits into from

Conversation

julien-lecomte
Copy link
Contributor

@julien-lecomte julien-lecomte commented Aug 16, 2024 •
edited
Loading

SUMMARY

gitlab_project - add option "analytics_access_level"
gitlab_project - add option "requirements_access_level"
gitlab_project - add option "requirements_enabled"

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

gitlab_project

ADDITIONAL INFORMATION

Since this branch will conflict with #8760 because of the mutual exclusive branches, I found it easier to manage by having this branch be merged after 8760.

@julien-lecomte julien-lecomte force-pushed the gitlab_project_add_params-2 branch 2 times, most recently from c4ca7a4 to 05c3947 Compare August 16, 2024 13:53
@ansibullbot
Copy link
Collaborator

cc @Lunik @Shaps @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) labels Aug 16, 2024
@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 16, 2024
@julien-lecomte julien-lecomte changed the title gitlab_project - add option "analytics_access_level" gitlab_project - add missing parameters Aug 16, 2024
@julien-lecomte julien-lecomte force-pushed the gitlab_project_add_params-2 branch 2 times, most recently from e1d04d8 to 0c5e026 Compare August 16, 2024 14:30
@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/gitlab_project.py:0:0: doc-default-does-not-match-spec: Argument 'requirements_enabled' in argument_spec defines default as (None) but documentation defines default as (True)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/gitlab_project.py:0:0: doc-default-does-not-match-spec: Argument 'requirements_enabled' in argument_spec defines default as (None) but documentation defines default as (True)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/gitlab_project.py:0:0: doc-default-does-not-match-spec: Argument 'requirements_enabled' in argument_spec defines default as (None) but documentation defines default as (True)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/gitlab_project.py:0:0: doc-default-does-not-match-spec: Argument 'requirements_enabled' in argument_spec defines default as (None) but documentation defines default as (True)

click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 16, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Aug 16, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Aug 24, 2024
@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 1, 2024
@julien-lecomte julien-lecomte deleted the gitlab_project_add_params-2 branch September 22, 2024 22:24
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch ci_verified Push fixes to PR branch to re-run CI feature This issue/PR relates to a feature request module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien-lecomte @ansibullbot @felixfontein