fix grpc_tls port value in config.json.j2

[garry-t]

SUMMARY

fix grpc_tls port value in config.json.j2

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

task

ADDITIONAL INFORMATION

Task failed with error

{"changed": false, "cmd": ["/usr/local/bin/consul", "validate", "-quiet", "/etc/consul/config.json", "/etc/consul.d"], "delta": "0:00:00.120234", "end": "2024-10-10 07:57:18.225071", "msg": "non-zero return code", "rc": 1, "start": "2024-10-10 07:57:18.104837", "stderr": "Config validation failed: failed to parse /etc/consul/config.json: 1 error(s) decoding:\n\n* 'ports.grpc_tls' expected type 'int', got unconvertible type 'string', value: '127.0.0.1'", "stderr_lines": ["Config validation failed: failed to parse /etc/consul/config.json: 1 error(s) decoding:", "", "* 'ports.grpc_tls' expected type 'int', got unconvertible type 'string', value: '127.0.0.1'"], "stdout": "", "stdout_lines": []}

[bbaassssiiee]

Thanks for the clear reporting and fix!

[JonathanGun]

this changes causes invalid config.

> head -n 6 /etc/consul/config.json
{
    "addresses": {
        "dns": "127.0.0.1",
        "grpc": "127.0.0.1",
        "grpc_tls": "-1",
        "http": "0.0.0.0",

> consul validate /etc/consul/config.json
Config validation failed: 1 error occurred:
	* addresses.grpc_tls: invalid ip address: -1

previous implementation would have been correct. default value of addresses.grpc_tls should be the client_addr . Ref. using the port value for address is incorrect.

The error mentioned in the PR, I believe, is coming from custom ansible inventory of @garry-t

https://github.com/ansible-collections/ansible-consul/pull/606/files#diff-32770839e59ae5da477388c7d674000df855dfcd601cc84471f8362bd24dd8ecR56

@bbaassssiiee please help to revert this commit. thanks

[bbaassssiiee]

Sorry for the merge, I created a revert PR.