Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Patrick Shriwise <[email protected]>
  • Loading branch information
aprilnovak and pshriwise authored Jan 11, 2023
1 parent 153502e commit 5c6980f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ build_dagmc:
$(info Skipping DagMC build because ENABLE_DAGMC is not set to 'yes')

build_moab:
$(info Skipping Moab build because ENABLE_DAGMC is not set to 'yes')
$(info Skipping MOAB build because ENABLE_DAGMC is not set to 'yes')

endif

Expand Down
4 changes: 2 additions & 2 deletions config/check_deps.mk
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ endif

ifeq ($(ENABLE_DAGMC), yes)
ifeq ($(DAGMC_CONTENT),)
$(error $n"DagMC does not seem to be available, but ENABLE_DAGMC is set to 'yes'. Make sure that the submodule is checked out.$n$nTo fetch the DagMC submodule, use ./scripts-get-dependencies.sh")
$(error $n"DagMC does not seem to be available, but ENABLE_DAGMC is set to 'yes'. Make sure that the submodule is checked out.$n$nTo fetch the DagMC submodule, use ./scripts/get-dependencies.sh")
endif
ifeq ($(MOAB_CONTENT),)
$(error $n"Moab does not seem to be available, but ENABLE_DAGMC is set to 'yes'. Make sure that the submodule is checked out.$n$nTo fetch the Moab submodule, use ./scripts-get-dependencies.sh")
$(error $n"Moab does not seem to be available, but ENABLE_DAGMC is set to 'yes'. Make sure that the submodule is checked out.$n$nTo fetch the Moab submodule, use ./scripts/get-dependencies.sh")
endif

DAGMC_status := $(shell git -C $(CONTRIB_DIR) submodule status 2>/dev/null | grep DAGMC | cut -c1)
Expand Down
2 changes: 1 addition & 1 deletion config/dagmc.mk
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ $(DAGMC_BUILDDIR)/Makefile: build_moab | $(DAGMC_DIR)/CMakeLists.txt
mkdir -p $(DAGMC_BUILDDIR)
cd $(DAGMC_BUILDDIR) && \
cmake -L \
-DBUILD_TALLY=ON \
-DBUILD_TALLY=OFF \
-DBUILD_TESTS=OFF \
-DBUILD_CI_TESTS=OFF \
-DBUILD_STATIC_LIBS=OFF \
Expand Down
2 changes: 1 addition & 1 deletion doc/content/options.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ set the following environment variable:
export ENABLE_OPENMC=false
```

We support an optional usage of DAGMC for CAD-based Monte Carlo transport.
We support the optional usage of [DAGMC](https://svalinn.github.io/DAGMC/)'s CAD-based models in OpenMC.
This capability is off by default, but to build with DAGMC support, set:

```
Expand Down
2 changes: 1 addition & 1 deletion doc/content/tutorials/dagmc.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ solid temperature is 500&deg;C and the initial power is zero.
### OpenMC Model

The OpenMC model is built using DAGMC. Particles move through space with surface-to-surface
tracking between tetrahedral surface meshes. Cells are the regions of space enclosed by
tracking between triangle surface meshes. Cells are the regions of space enclosed by
these surfaces. After building the DAGMC model with Cubit, we set up the OpenMC input files
using the Python [!ac](API). First, we define
materials, then fetch the geometry from the DAGMC geometry file (`dagmc.h5m`). Then, we
Expand Down

0 comments on commit 5c6980f

Please sign in to comment.