feat: thread-based translation #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h/ansari-backend into whatsapp-misc-enhancements
* Use threads logic instead of asyncio logic when translation citations from Arabic to English
Details: * In the previous commit (diff with the one before it), this line was present inside _finish_response's for loop: `...translate_texts_parallel([arabic_text],...)` * The `[arabic_text]` part means that I was accidentally passing only one arabic text, so the thread was actually working sequentially (per each for loop iteraction) * Therefore, refactored the code to gather up the required texts to be translated in one pass, then batch-translate them in another pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Implement thread-based translation fallback to enhance async handling in AnsariClaude