-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: image component for both external and internal use #6359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
@vimtor the test in # Unhandled error between tests
-------------------------------
26 | // high-quality error messages.
27 | //
28 | // As a side-effect of importing this file, we must enable the --allow-natives-syntax V8 flag. This
29 | // is because we are using V8 intrinsics in order to implement this module.
30 | const v8 = __importStar(require("v8"));
31 | v8.setFlagsFromString("--allow-natives-syntax");
^
NotImplementedError: node:v8 setFlagsFromString is not yet implemented in Bun.
code: "ERR_NOT_IMPLEMENTED"
at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/closure/v8.js:31:4
at anonymous (unknown:1:1)
at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/closure/createClosure.js:29:7
at anonymous (unknown:1:1)
at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/closure/serializeClosure.js:61:78
at anonymous (unknown:1:1)
at /Users/menglinmaker/Documents/software-projects/open-source/sst/node_modules/@pulumi/pulumi/runtime/index.js:29:1 |
|
hey @MengLinMaker no need to upgrade i'm working on a better testing setup. for the moment you can test the components against one of the local examples as described in the README |
|
AFAIK some Are you implying the local sst should be installed globally? |
|
Ah thanks its in the root README Then |
|
i usually do:
if you make changes you should run 4 and 6 again |
|
Not quite ready to merge, but I'd like confirm that current changes are desired. Refactoring Adding ability to use input image directly into |
Adding Image component for #6304:
image.tscomponent:function.tsandfargate.tsto useimage.tsfunction.tsfargate.tsexamples:examples/aws-taskexamples/aws-python-container- only python uses container for Lambda functionAlthough efforts has been made to preserve functionality. Some behaviors may change:
fargate.tsimage name is changed. Can be preserved via transform.