Skip to content

fix: don't import all of pulumi and aws, rather use existing imports#6357

Open
JanStevens wants to merge 1 commit intoanomalyco:devfrom
JanStevens:fix/imports-in-ssr-site
Open

fix: don't import all of pulumi and aws, rather use existing imports#6357
JanStevens wants to merge 1 commit intoanomalyco:devfrom
JanStevens:fix/imports-in-ssr-site

Conversation

@JanStevens
Copy link
Contributor

In search of circular references I came across this one and it seems like an odd thing to do:

  1. It's not done in any other part of the code base
  2. All imports for aws where already there
  3. asset as pulumiAsset is already being done elsewhere

It also seems "dangerous" to include all of pulumi and aws.

I guess eslint rules would help here but for now this should already potentially prevent any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant