Fix Function.addEnvironment not updating on redeploy#6338
Open
vimtor wants to merge 1 commit intoanomalyco:devfrom
Open
Fix Function.addEnvironment not updating on redeploy#6338vimtor wants to merge 1 commit intoanomalyco:devfrom
Function.addEnvironment not updating on redeploy#6338vimtor wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6264
the diff logic was incorrect because
removing
Diffentirely lets Pulumi use its default input comparison, which correctly detects when theenvironmentchanges. we are already doing something similar for theaws-function-code-updater.goproof of it working
change
TEST=5678and redeploy: