fix: don't re-capture console in restoreOriginalConsole#556
Open
murrayju wants to merge 1 commit intoanomalyco:mainfrom
Open
fix: don't re-capture console in restoreOriginalConsole#556murrayju wants to merge 1 commit intoanomalyco:mainfrom
murrayju wants to merge 1 commit intoanomalyco:mainfrom
Conversation
The restoreOriginalConsole method was calling setupConsoleCapture() after restoring the original console, which immediately re-captured it. This prevented console.log output from appearing after renderer.destroy() was called. This fix removes the errant setupConsoleCapture() call so that deactivating the console capture actually restores normal console behavior.
Collaborator
|
@msmps I remember darkly that there was a weird reason for this. Looking at it again it doesn't make sense. I know that there is no test coverage for this, so even though it makes sense, I am not sure what it would break. Only thing I see is that console activate/deactivate was meant for the "debug console view" and if it should capture console log calls, which is different from the "capture", which makes sure console.* calls do not interfere with stdout. Maybe it would make sense to have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
restoreOriginalConsolemethod was callingsetupConsoleCapture()after restoring the original console, which immediately re-captured it. This preventedconsole.logoutput from appearing afterrenderer.destroy()was called.Problem
When using
createCliRendererand then callingrenderer.destroy(), anyconsole.logstatements after the destroy call would not appear in the terminal. This is because:renderer.destroy()callsthis._console.destroy()deactivate()restoreOriginalConsole()restoreOriginalConsolerestoresglobal.consolebut then immediately callssetupConsoleCapture()which re-captures itSolution
Remove the errant
setupConsoleCapture()call fromrestoreOriginalConsole()so that deactivating the console capture actually restores normal console behavior.Testing
After this fix, the following pattern works correctly: