perf: add early-out for transparent overlay in blendColors#498
Open
simonklee wants to merge 4 commits intoanomalyco:mainfrom
Open
perf: add early-out for transparent overlay in blendColors#498simonklee wants to merge 4 commits intoanomalyco:mainfrom
simonklee wants to merge 4 commits intoanomalyco:mainfrom
Conversation
simonklee
force-pushed
the
buffer-blend-early-out
branch
2 times, most recently
from
8932149 to
c4d648a
Compare
Skip pow and vector math when overlay alpha is fully transparent, returning text color directly. The common case for text backgrounds.
simonklee
force-pushed
the
buffer-blend-early-out
branch
from
a8f5ebf to
e12f72e
Compare
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a fast path when overlay alpha is fully transparent, returning text color directly.