fix: filter whitespace-only content for all providers#8954
Open
nathannewyen wants to merge 1 commit intoanomalyco:devfrom
Open
fix: filter whitespace-only content for all providers#8954nathannewyen wants to merge 1 commit intoanomalyco:devfrom
nathannewyen wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #7086: "fix(provider): trim whitespace and filter empty content in transformations" This PR appears to address the same issue - filtering and trimming whitespace content across provider transformations. The current PR #8954 is likely implementing a similar or identical fix. You should:
|
Apply consistent whitespace trimming across all provider transformations. Trim text content before checking if empty, filter whitespace-only messages and text parts for all providers. Fixes anomalyco#8903
nathannewyen
force-pushed
the
fix/whitespace-content-validation
branch
from
59b8666 to
cee52ce
Compare
Collaborator
|
pretty sure glm models have a weird behavior where they do empty text that actualy has to get sent back or something I remember there being some weird bug last time I tried this |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8903