Repository navigation
fix(tui): open file links in the default application - #57295
Closed
maharshi365 wants to merge 2 commits into
Closed
maharshi365 wants to merge 2 commits into
maharshi365 wants to merge 2 commits into
Conversation
Route explicit file URLs through the existing path launcher while preserving web URL handling. Use the shared dispatcher for markdown clicks and Link components. Add isolated regression coverage for local files, web URLs, and rejected inputs.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
Thanks for picking this up, @maharshi365! I think this duplicates #55769, which is still open (it replaced the closed #54838 for #54816). It changes the same two places, the transcript link click in
If your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related to #57288 and #54816.
Type of change
What does this PR do?
Route explicit
file://links in the TUI through the built-inopenPathhelper so they open in the system default application. Convert the file URL to a native path withfileURLToPathfirst.Both transcript link clicks and the
Linkcomponent use this dispatcher. HTTP/HTTPS links still useopenUrl, with its existing validation unchanged.This is limited to explicit
file://links. Bare absolute or relative file paths, such as the example in #54816, are not handled by this change. No new launcher dependency or configuration is added.How did you verify your code works?
bun test test/ui/open-link.test.tsfrompackages/tui: passed.bun run checkfrom the repository root: passed with lint warnings.Screenshots / recordings
Recording.2026-10-20.011113.mp4
Checklist