Conversation
Databases migrated from V1 keep the legacy session/message/part/todo store alongside session_v2, but the Deleted projection only removed the V2 row, orphaning the legacy copy forever. Guard a legacy delete on a schema lookup so fresh and renamed-lineage databases skip it, and let the legacy foreign keys cascade the child rows.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #50260
Type of change
What does this PR do?
Deleting a session only removed its
session_v2row, so databases that came in through the V1→V2 migration kept the legacysession/message/part/todocopies forever — unreachable from the UI but still holding space that VACUUM can't reclaim. The Deleted projection in packages/core/src/session/projector.ts now also deletes the legacy parent row when the legacysessiontable exists, and the legacy foreign keys cascade the child rows from there. Fresh and renamed-lineage V2 databases have no legacy table, so the delete is guarded by a sqlite_master lookup.How did you verify your code works?
Added a regression test in packages/core/test/session-remove.test.ts that materializes the legacy store, installs matching legacy rows, runs Session.remove, and asserts every legacy table is empty afterwards. bun test test/session (612 pass) and bun typecheck are green. Workaround from the report (
DELETE FROM session WHERE id NOT IN (SELECT id FROM session_v2); VACUUM;) still applies for rows orphaned before this fix.Screenshots / recordings
Not a UI change.
Checklist