Skip to content

fix(cli): keep mini session waits alive - #50248

Open
andreivince wants to merge 1 commit into
anomalyco:v2from
andreivince:mini-wait
Open

andreivince wants to merge 1 commit into
anomalyco:v2from
andreivince:mini-wait

Conversation

@andreivince

@andreivince andreivince commented Sep 20, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #50135

Targets v2 per CONTRIBUTING.md. The issue-link warning is the existing workflow problem described in #43964.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Mini's session wait can outlive Bun's default fetch idle timeout and terminate with ClientError: Transport. Use the same timeout policy as run for initial and reconnected clients. Explicit cancellation still works, and the prompt is never resubmitted.

How did you verify your code works?

  • The new subprocess regression failed before the fix. A delayed local server proves default fetch times out while both mini clients keep waiting; caller cancellation still rejects.
  • 21 mini tests and 90 TUI transport/queue tests pass.
  • Repository lint and all 35 package typechecks pass. The native macOS ARM64 CLI builds and its startup/help checks pass.
  • Full CLI suite: 284 pass and four ACP failures. Three reproduce on the unchanged baseline; the remaining cancellation test passes isolated reruns on both the baseline and this commit.

Screenshots / recordings

No visual change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Copilot AI lite review requested due to automatic review settings September 20, 2026 23:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants