Skip to content

fix(opencode): expose and use auth confirmation code#30543

Open
OpeOginni wants to merge 10 commits into
anomalyco:devfrom
OpeOginni:fix/desktop-provider-oauth-view
Open

fix(opencode): expose and use auth confirmation code#30543
OpeOginni wants to merge 10 commits into
anomalyco:devfrom
OpeOginni:fix/desktop-provider-oauth-view

Conversation

@OpeOginni

@OpeOginni OpeOginni commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #30541

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

When using Oauth Connection of any kind the Desktop UI shows Confirmation Code even if there isnt any passed or needed.

  • This PR checks for if any code is given and if none is found doesnt render the Confirmation Code component.
  • It also adds translations for the new text show when only broswer auth is used without a confirmation code.

How did you verify your code works?

  • Passed Typecheck
  • Tested For provider auth methods without codes and those with codes and does with code to make sure of no regression. (check video below)

Screenshots / recordings

Screen.Recording.2026-06-03.at.12.06.07.mov

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Comment thread packages/app/src/components/dialog-connect-provider.tsx Outdated
Comment thread packages/app/src/i18n/de.ts Outdated
@OpeOginni OpeOginni changed the title fix(desktop): Remove confirmation code comp for oauth without code fix(opencode + desktop): OAuth passes in code separate from instructions Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Hey! Your PR title fix(opencode + desktop): OAuth passes in code separate from instructions doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@OpeOginni OpeOginni changed the title fix(opencode + desktop): OAuth passes in code separate from instructions fix(opencode + desktop): expose and use auth confirmation code Jun 5, 2026
@OpeOginni OpeOginni changed the title fix(opencode + desktop): expose and use auth confirmation code fix(opencode): expose and use auth confirmation code Jun 5, 2026
@OpeOginni

Copy link
Copy Markdown
Contributor Author

NEW LOOK

Trimmed.mov

…r-oauth-view

# Conflicts:
#	packages/tui/src/component/dialog-provider.tsx
@OpeOginni OpeOginni requested a review from Brendonovich as a code owner June 8, 2026 11:46
@OpeOginni OpeOginni requested a review from Hona June 8, 2026 11:47
@OpeOginni

Copy link
Copy Markdown
Contributor Author

@Hona any feedback on the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Desktop Oauth shows Confirmation Code for connection methods that don't provide such

2 participants