feat(app): add transparent Open in icon toggle#12641
feat(app): add transparent Open in icon toggle#12641edoedac0 wants to merge 9 commits intoanomalyco:devfrom
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
64904d8 to
06b3455
Compare
02067d4 to
dcb145c
Compare
|
@edoedac0 doesnt need to be a setting, we should use this instead of the white bg, but I think we need to make sure every icon looks good on light and dark mode. In your screenshot zed needs to be the dark mode version of their icon. Will need to support two versions for some of these (light and dark). |
yeah ur right, i will make a new commit soon with two versions for some icons that need it |
Here, I also updated finder icon to the tahoe version for all users with macos tahoe |
|
@edoedac0 sorry, last request: let's just use the Tahoe icon always for finder, removes a bunch of complexity |
632f45f to
f5611e3
Compare
No problem, here it is |
|
btw @adamdotdevin what do you think about this pr #12722 ? |
|
@edoedac0 please remove the setting, we'll just always have transparent icons, please clean all that up and I'll merge |
Love it |
|
/oc remove the conditional nature of this improvement, we should always use transparent images, please remove the changes to settings, locale changes, etc, clean it all up |
Co-authored-by: adamdotdevin <adamdotdevin@users.noreply.github.com>
|
All changes have been applied successfully. Let me provide a summary of what was cleaned up: SummaryRemoved the conditional "transparent app icons" setting and made transparent images the default behavior:
|
Sorry I wasn't on pc, my bad I forgot to push that. Do I still need to or the bot took care of it? |
Greatt, is it good for merging? |
Could you test and make sure it still looks good? Also, I think it touched the English locale file still, could you remove that change? |
yeah |
everything looks good on my end, for the english file it just removed:
|



Summary