feat(acp): include subagents in available modes response#12305
Open
YichenLi00 wants to merge 1 commit intoanomalyco:devfrom
Open
feat(acp): include subagents in available modes response#12305YichenLi00 wants to merge 1 commit intoanomalyco:devfrom
YichenLi00 wants to merge 1 commit intoanomalyco:devfrom
Conversation
- Remove subagent filter from loadAvailableModes - Add mode field to response for client-side filtering - Maintains backward compatibility (same data shape, more entries)
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
rekram1-node
reviewed
Feb 5, 2026
| id: agent.name, | ||
| name: agent.name, | ||
| description: agent.description, | ||
| mode: agent.mode, |
Collaborator
There was a problem hiding this comment.
ModeOption doesnt even have a mode field
also I dont understand, why would a subagent be in the selectable list. That seems inconsistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11576
Changes
Remove subagent filter from
loadAvailableModesand addmodefield to response, letting clients decide what to display.Backward Compatibility
Same data shape, just with more entries and an additional
modefield. Existing clients can filter bymodeif needed.