feat: exclude devtools from production builds#12290
Open
sneycampos wants to merge 3 commits intoanomalyco:devfrom
Open
feat: exclude devtools from production builds#12290sneycampos wants to merge 3 commits intoanomalyco:devfrom
sneycampos wants to merge 3 commits intoanomalyco:devfrom
Conversation
- Add tauri/devtools to default features for development - Add --no-default-features to production builds in CI - Simplify Cargo.toml feature configuration - Add tauri:dev script to package.json
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found. |
rekram1-node
requested review from
Brendonovich
and removed request for
adamdotdevin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
For production, i ran
cargo build --release --no-default-featuresand verified in the output that no devtools flags were being passed to tauri and the build completed successfully without devtoolsThe right-click shows only "reload"
For development, I ran a regular
cargo build --releaseand confirmed that feature="devtools" shows up in the rustc commands for tauri and rancargo metadatato confirm the features section shows default = ["tauri/devtools"]The right-click shows the reload and inspect (and opens the devtools)
Fixes #10301, #12080