fix(opencode): correct prefix selection for amazon-bedrock provider in getSmallModel#12281
Open
NachoFLizaur wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): correct prefix selection for amazon-bedrock provider in getSmallModel#12281NachoFLizaur wants to merge 1 commit intoanomalyco:devfrom
NachoFLizaur wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12280
getSmallModel()returns the first model matching a priority string from the provider models. Due to models.dev JSON key ordering, EU-prefixed models are returned first, causing title generation to fail when the configured AWS Region is not in eu.The fix adds Bedrock-specific logic to prefer
global.prefixed models, with fallback to regional prefix (us.,eu.) depending on the user's region.Support for other regional prefixes (jp, apac, au) not added as models.dev doesn't support them at the moment.
How did you verify your code works?
After the fix, I tested by setting
AWS_REGIONto a non-european region (us-west-2) and verifying that the title was generated correctly.