Update regex to preserve specific paths in sanitization#42
Open
eXamadeus wants to merge 1 commit intoanomalyco:masterfrom
Open
Update regex to preserve specific paths in sanitization#42eXamadeus wants to merge 1 commit intoanomalyco:masterfrom
eXamadeus wants to merge 1 commit intoanomalyco:masterfrom
Conversation
Author
|
@rekram1-node let me know if you'd like a deeper show of testing. I validated the regex pretty thoroughly, but I'm not 100% certain on how Anthropic will handle the Windows paths. I can't imagine it causing issues and it didn't seem to in my testing. But I didn't test the auth plugin on Windows either /shrug |
|
Just spent a day chasing down a gnarly problem that this exact PR fixes. @rekram1-node you probably don't like being @ mentioned but this PR being merged would've saved me quite the amount of hours and pain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #41
The change is to extend the power of the negative lookbehind to allow for more path structures.
Verification
This Regexr link has good examples of how this works.
Screenshot if the link ever breaks
Blue highlights show what is replaced with
Claude