chore(vendor): refresh geb-mathlib and extend the module exclusions - #303
Merged
Merged
Conversation
Refresh the vendored `geb-mathlib` tree to upstream 17f8f4c. The
refresh workflow failed on the modules upstream added under
`Geb.Prototypes.Computability.BitTree`, `BitTreeScanner`, and
`Mazzanti`, which import
`Cslib.Computability.Machines.Turing.MultiTape.{Deterministic,TapeLemmas}`
and `Cslib.Foundations.Data.PFunctor.Free`. None of the three exists at
the pinned cslib revision `9a159ac`; `PFunctor/Free.lean` was added in
cslib PR #477, and the pinned tree's `Cslib.FreeM` is the free monad
over an arbitrary type constructor rather than over a polynomial
functor, so no rename supplies it.
Extend the exclusion list with the modules importing those, the
modules importing one of them in turn, and the modules whose every
importer is excluded (which `scripts/tests/test-lint-driver.sh`
reports as orphaned from the `Geb` umbrella). The index modules
survive with their imports deleted. Render the list in
`PROVENANCE.md` one entry per line.
Extend the back-port patch for the surviving new modules: the
category 11 lemma renames in `BitTree/Encoding.lean`,
`Mazzanti/Derived.lean`, and `Mazzanti/Diagonal.lean`; category 4 `beta_reduce` sites in
`BitTree/Elias/Tree.lean`, `SizeBounded/Basic.lean`, and
`SizeBounded/Cost.lean`; the category 3 `Type`-valued identity law in
`Presheaf/WalkingArrow.lean`; and the category 8 and 13
`unusedArguments` suppressions in `SizeBounded/Cost.lean` and
`SizeBounded/BitTree.lean`. Record each in
`docs/geb-mathlib-backport-notes.md`.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019F44EyCXtUXKqzxxQGzdmP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh the vendored
geb-mathlibtree to upstream 17f8f4c. The refresh workflow failed on the modules upstream added underGeb.Prototypes.Computability.BitTree,BitTreeScanner, andMazzanti, which importCslib.Computability.Machines.Turing.MultiTape.{Deterministic,TapeLemmas}andCslib.Foundations.Data.PFunctor.Free. None of the three exists at the pinned cslib revision9a159ac;PFunctor/Free.leanwas added in cslib PR #477, and the pinned tree'sCslib.FreeMis the free monad over an arbitrary type constructor rather than over a polynomial functor, so no rename supplies it.Extend the exclusion list with the modules importing those, the modules importing one of them in turn, and the modules whose every importer is excluded (which
scripts/tests/test-lint-driver.shreports as orphaned from theGebumbrella). The index modules survive with their imports deleted. Render the list inPROVENANCE.mdone entry per line.Extend the back-port patch for the surviving new modules: the category 11 lemma renames in
BitTree/Encoding.lean,Mazzanti/Derived.lean, andMazzanti/Diagonal.lean; category 4beta_reducesites inBitTree/Elias/Tree.lean,SizeBounded/Basic.lean, andSizeBounded/Cost.lean; the category 3Type-valued identity law inPresheaf/WalkingArrow.lean; and the category 8 and 13unusedArgumentssuppressions inSizeBounded/Cost.leanandSizeBounded/BitTree.lean. Record each indocs/geb-mathlib-backport-notes.md.