chore(vendor): refresh geb-mathlib and extend the back-port patch - #300
Merged
Merged
Conversation
Refresh vendor/geb-mathlib to upstream caf42ee, which splits
Geb/Mathlib/CategoryTheory/Grothendieck.lean into Grothendieck/Basic.lean
and Grothendieck/Functor/{Between,From,To}.lean.
Grothendieck/Functor/From.lean does not compile under v4.29.0-rc6: Lean
core has narrowed the backward-compatibility option
backward.isDefEq.respectTransparency to
backward.isDefEq.respectTransparency.types, and the isDefEq change that
the option compensates for also decides several unifications in that
module differently. Extend the back-port patch with a stanza for the
module: substitute the v4.29 option spelling, set the option on
natTransFrom and NatTransFromData.comp, and append a closing rfl to
Functor.leftOpEquiv's functor_unitIso_comp field and to
CoGrothendieck.FunctorFromData.mk's hom_id field.
Record the adaptation as category 16 of the back-port notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh vendor/geb-mathlib to upstream caf42ee, which splits Geb/Mathlib/CategoryTheory/Grothendieck.lean into Grothendieck/Basic.lean and Grothendieck/Functor/{Between,From,To}.lean.
Grothendieck/Functor/From.lean does not compile under v4.29.0-rc6: Lean core has narrowed the backward-compatibility option backward.isDefEq.respectTransparency to
backward.isDefEq.respectTransparency.types, and the isDefEq change that the option compensates for also decides several unifications in that module differently. Extend the back-port patch with a stanza for the module: substitute the v4.29 option spelling, set the option on natTransFrom and NatTransFromData.comp, and append a closing rfl to Functor.leftOpEquiv's functor_unitIso_comp field and to CoGrothendieck.FunctorFromData.mk's hom_id field.
Record the adaptation as category 16 of the back-port notes.