Refresh vendored geb-mathlib - #292
Merged
rokopt merged 2 commits intoAug 14, 2026
Merged
Conversation
A vendored module whose dependency does not exist at the pinned mathlib and cslib revisions cannot be adapted by a patch hunk, and `sorry` is not permitted in committed code. Give the refresh script an exclusion list naming such modules: each is removed with its submodule directory, and every import of it or of one of its submodules is deleted from the surviving files, leaving no bad import. The removal runs after `git apply` so that patch hunks still anchor against the pristine upstream text they were generated from, and `PROVENANCE.md` records the list, the vendored tree now being a function of it as well as of the upstream commit and the patch. Exclude `Geb.Internal.Computability.TreeScanner`, which imports `Cslib.Computability.Machines.Turing.MultiTape.Deterministic` and `Cslib.Computability.Machines.Turing.MultiTape.TapeLemmas`. Both were added to cslib after the pinned revision `9a159ac` (`v4.29.0-rc6`), whose only Turing-machine material is `Cslib.Computability.Machines.SingleTapeTuring.Basic`; cslib's history records both as additions rather than as renames of anything present at the pin.
The upstream delta since `871cfad` is the new `Geb.Internal.Computability` namespace. Its `TreeScanner` subtree is dropped by the refresh script's exclusion list, so the mirrored content that changes is the namespace index module and the import of it in `Geb/Internal.lean`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case the new code built on cslib infrastructure (Turing machines and computational complexity) not available in our older version, so we simply exclude it from vendoring.