Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update promise.ts #717

Closed
wants to merge 1 commit into from
Closed

Update promise.ts #717

wants to merge 1 commit into from

Conversation

MrHBS
Copy link

@MrHBS MrHBS commented Jul 20, 2023

I believe you should always use async/await over callbacks and .then(). Let me know if you disagree.

@MrHBS MrHBS requested a review from prisis as a code owner July 20, 2023 23:04
@prisis
Copy link
Member

prisis commented Jul 25, 2023

I did deactive this 2 rules because there are some bugs with it.

For example: eslint-community/eslint-plugin-promise#294, eslint-community/eslint-plugin-promise#212, eslint-community/eslint-plugin-promise#179

Would say for the current this is on hold, for my point of view :)

@MrHBS
Copy link
Author

MrHBS commented Jul 25, 2023

Got it 👍

Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants