-
-
Notifications
You must be signed in to change notification settings - Fork 295
feat: Enable OAuth 3LO support #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christianarty
wants to merge
70
commits into
ankitpokhrel:main
Choose a base branch
from
christianarty:add-oauth-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
40b055a
(build) Update Golang OAuth2 Library to latest
christianarty b615be3
(feat) Implement OAuth2 func. into jira-cli
christianarty 23a3c5d
feat:(oauth) - Ability to get cloud id for clients
christianarty eb98589
(docs) Add note about OAuth weirdness
christianarty 722e4d9
(refactor) Move oauth to separate module
christianarty 007f761
(refactor) Remove unnecessary args from `verifyLoginDetails` and `con…
christianarty e4cc1c2
(tests): Add tests for oauth
christianarty 691edbb
(nit) Move getToken logic into separate func
christianarty f57474b
(refactor) Organizing the oauth to break up the logic to other files
christianarty 40402e6
(feat) Add the ability to load the persisted oauth token from filesystem
christianarty ca6a100
(test) More tests for oauth
christianarty 00d31d5
(feat) Enable auto refreshing access tokens through the oauth2 custom…
christianarty c5533a8
(nit) remove dead code
christianarty d7917e9
(fix) The constructed server urls were pointing to authorization serv…
christianarty 2af8279
(docs) update README with more instructions.
christianarty 605d9f0
(fix/cleanup) Remove old/redundant code and fix the oauth tests
christianarty 7264fa9
(nit) Remove old TODO
christianarty b4b3d62
(lint) fix the lint issues
christianarty 0d0e03a
(ci/fix) Fix tests to allow for ci to pass quality checks
christianarty aada4f6
(ci) Fix some more issues found with DeepSource
christianarty b9aa1be
(docs) update README to account for discussion post
christianarty bf3fce8
(nit) add additional scopes for properly reading jira sprint
christianarty 99f1bb6
need this scope for adding to a sprint
christianarty 6282035
typos
christianarty a59a503
address the searching for epic details
christianarty 619badc
fix reason why the cloud isn't working
christianarty e171f6c
linting
christianarty e6104a8
reorganize the storage and filesystem tests
christianarty 8de8754
add a keyring storage and some tests
christianarty f655fe8
filesystem should work similar to keyring
christianarty da55c8c
[test] add storage_test
christianarty 772471d
update keyring storage to remove some unless comments
christianarty acf64fc
add a way for use a fallback storage for saving the token
christianarty b6caa86
(fix) separating the login details and the server details
christianarty 0c6e24d
(nit) remove the testService in the keyring storage test
christianarty 5cd847c
(fix) pass around the login field to the oauth token so the keyring w…
christianarty bc29aa8
(lint) make lint
christianarty fd7e189
nit: shouldn't pretty print an oauth file
christianarty 1c9cd80
add a compression to the string before saving
christianarty 761ef92
(fix) allow for tests to work and catch bug with loading json file
christianarty 666d2aa
(feat) add env variable workarounds
christianarty f78deae
(nit) Rely on the keyring to emit the size error rather than us
christianarty 606fedd
(feat) add warning for when the filesystem storage is used
christianarty 471e1f4
(improv) the HTML page was ugly 🤷🏾♂️
christianarty 2a83db3
(test) add the assertion that we fallback to fs when keyring fails
christianarty 072b00d
(improv) moved warning to fs storage
christianarty 63d5650
(fix) consistent env names, and add override for cloud id
christianarty 662e4e6
update readme
christianarty 35ed32a
(lint) fix errors
christianarty 3acccb6
deepsource was yelling at me
christianarty ee1343f
(feat) print out expected scopes when initializing
christianarty 5a751c7
(nit) minor addition to the printing of expected scopes
christianarty 6680e93
(pr) rename cloudId to be consistent
christianarty f49ce94
(pr-nit) oauth canonical
christianarty 3006834
(pr) use Jira AuthType for options
christianarty a1c1617
(pr) path escape cloudid
christianarty 38c5fc4
(pr-fix) c.JiraClient was checking if !nil, when it should be
christianarty a1b4bcc
(pr) move and use accessibleURL to cloud_id
christianarty 858d625
(pr) rename cloudid file
christianarty 4be38c9
(pr) fix the way we set the clientID and ClientSecret from env
christianarty 62878e2
(pr) refactor the scopes to be a struct to properly print and use
christianarty 3362e6e
(nit) remove a useless test
christianarty a7270c6
(nit) this should be before setting the apiServer not after
christianarty bdabb55
Update README.md
christianarty 69a45c3
Update pkg/utils/keyring_storage.go
christianarty 00a3792
(pr-nit) oauth name
christianarty 3b2414c
(pr-nit) add AccessibleURL
christianarty fb011af
(pr-nit) godoc comments
christianarty 8eed942
(pr-nit) rename to follow conventions
christianarty 8fe3460
(pr-improv) use slices.SortFunc for a simpler sort when printing expe…
christianarty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.