Track clicks when element inside of <a href> tag is clicked.#54
Merged
Conversation
Owner
|
Hey @fleitz, thanks for the PR, and sorry for the delay (have been focused on other projects). This change makes sense to me. Instead of setting |
Contributor
Author
|
Yeah, that sounds like a way cleaner way to implement. |
Contributor
Author
|
@ankane implemented. |
ankane
reviewed
Oct 7, 2020
ankane
reviewed
Oct 7, 2020
| return obj; | ||
| } | ||
|
|
||
| function eventProperties(e) { |
ankane
reviewed
Oct 7, 2020
Owner
|
Thanks @fleitz! This is a great feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<a href="#foo"> <div> <img src="clickable_image"> </div> </a>Expected result: Clicking on image results in tracking
Actual Result:
Clicking on image does not result in tracking.