Skip to content

Anirudh and Saatvik Lab 3 Completed#6

Open
saatvik7 wants to merge 20 commits intolab2from
lab3
Open

Anirudh and Saatvik Lab 3 Completed#6
saatvik7 wants to merge 20 commits intolab2from
lab3

Conversation

@saatvik7
Copy link
Copy Markdown
Collaborator

@saatvik7 saatvik7 commented Nov 5, 2021

No description provided.

@nrhodes-hmc nrhodes-hmc self-assigned this Nov 17, 2021
@nrhodes-hmc
Copy link
Copy Markdown
Collaborator

Starting: 90

Nice (+2 each):

  • favicon and title
  • Much testing

Not-so-nice (-2 each):

  • UI: Filter By: doesn't filter. should be Sort by:
  • What's the initial sort criterion? (can't tell just by clicking on Filter By)

Total: 90

Sorty by name reverse alphabetically?
There's an orange horizontal line under one of the items. Unsure why it's there.
editing task names doesn't save them to DB (but editing priority or completed does)

App.js, line 35: indentation
App.js, line 62: setFilter(filter) is a no-op (it's setting the state to its current value)
App.js, line 72: getFilteredList should just get something (based on its name). Shouldn't set something.
To-DoList.js, line 46: const, not let
To-DoList.js, line 46: never compare boolean expression against true or false
To-DoList.js, line 48: no need to set numCompleted to 0. it'll get re-evaluated on next render.

@nrhodes-hmc
Copy link
Copy Markdown
Collaborator

Updated:
Starting: 90

Nice (+2 each):

  • Updated alignment based on design lecture
  • favicon and title
  • Much testing

Not-so-nice (-2 each):

  • UI: Filter By: doesn't filter. should be Sort by:
  • What's the initial sort criterion? (can't tell just by clicking on Filter By)

Total: 92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants