Skip to content

Anirudh and Saatvik Lab 1 Completed.#2

Open
saatvik7 wants to merge 30 commits intolab1-beginningfrom
lab1
Open

Anirudh and Saatvik Lab 1 Completed.#2
saatvik7 wants to merge 30 commits intolab1-beginningfrom
lab1

Conversation

@saatvik7
Copy link
Copy Markdown
Collaborator

No description provided.

@nrhodes-hmc nrhodes-hmc self-assigned this Oct 4, 2021
Comment thread design.md
(Saatvik Sejpal, Anirudh Satish
)

## Design Decisions
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context of what is being designed would be good.

Comment thread design.md
Although this probably looks cool, this is not ideal as the user needs to search for the "plus"
button each time, and therefore we decided against the same.
We also thought about having a separate section for completed items at the bottom of the screen; however, we decided
to just do away with having a separate section and just float the completed tasks to the bottom of the page when we mark them
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of moving completed tasks to the bottom

Comment thread design.md

### Task 1: Adding a task to an empty list

Screen at the Beginning of the task:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a thing to-do?

Comment thread design.md

Screen during the process of adding the item to the list:

<img src='Screenshots/IntermediateTask2.png' width=50%/>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have circles to mark items as completed. However, they look like radio buttons, which only allow one item to be selected. Have you considered using squares instead?

Comment thread design.md
Screen at the Beginning of the task:

<img src='Screenshots/PreTask4.png' width=50%/>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you move from first image to second. Is it long-press? If so, say so

Comment thread design.md

<img src='Screenshots/IntermediateTask4.png' width=50%/>

Screen after renaming the item:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you finish the rename? What was the user action?

Comment thread design.md
than just not showing the completed tasks.

Screen at the Beginning of the task:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Text John about bank statements" breaks so that "statements" is below the orange circle. Shouldn't it be left-aligned with "Text"

Comment thread design.md
Screen after deleting all completed tasks:

<img src='Screenshots/PostTask6.png' width=50%/>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete Completed button is still enabled, even though there aren't any completed items. Should it be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants