-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for UnitSystem methods #708
Conversation
Added benchmarks for UnitSystem methods (UnitSystem.SI)
BenchmarkDotNet=v0.11.5, OS=Windows 10.0.17763.737 (1809/October2018Update/Redstone5)
|
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=======================================
Coverage 58.32% 58.32%
=======================================
Files 166 166
Lines 37811 37811
=======================================
Hits 22055 22055
Misses 15756 15756 Continue to review full report at Codecov.
|
Great, thanks! |
A quick note: the performance of the SI methods tested in this release are actually dependent on the quantity that is tested; here we test Length- which has ~ 30 UnitInfos (meter being in the middle), where for example VolumePerLength has only 3- thus it seems your result may vary (being slightly lower for most other quantities, on average):
|
Right. I don't recall the exact implementation for looking up the conversion functions from the top of my head, it has changed a few times lately, but I'm sure it can be improved. Maybe as simple as using a dictionary if we are not already using that. |
Added benchmarks for UnitSystem methods (UnitSystem.SI) in order to use as base line for comparison (I see there is a tool for that) with the modifications envisioned in #651