Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

docs: Adds note about default unit for fxFlex if none given #780

Merged

Conversation

peterramsing
Copy link
Contributor

Maybe I'm missing something, but this might be helpful to specify.

@peterramsing
Copy link
Contributor Author

I'm not entirely sure how my changes broke the build. I'll look at it later to see what's up.

@julianobrasil
Copy link

julianobrasil commented Jun 14, 2018

This info is already in the docs, but buried in the Responsive API wiki. I also think it's hard to find, dispite the fact that some examples kind of suggest it.

@peterramsing
Copy link
Contributor Author

@julianobrasil, yup, that is pretty well doc'd in the Responsive API section. I'd almost want to bring that formatting to what I did if what I wrote should even go where I put it.

@peterramsing
Copy link
Contributor Author

peterramsing commented Jun 24, 2018

@ThomasBurleson, I suppose this PR might be the tip of a documentation iceberg for me. Is there any other documentation that I could help with? Are there any areas outside of #598 that I could help with?

@CaerusKaru
Copy link
Member

Please rebase to resolve the test failure

@CaerusKaru CaerusKaru self-assigned this Jul 25, 2018
@CaerusKaru CaerusKaru added this to the v6.0.0-beta.17 milestone Jul 25, 2018
@peterramsing peterramsing force-pushed the adds-default-unit-to-fxflex-docs branch from 5297471 to 1996b42 Compare July 26, 2018 16:51
@peterramsing
Copy link
Contributor Author

@CaerusKaru Done.

@CaerusKaru CaerusKaru merged commit cdf1368 into angular:master Jul 27, 2018
@peterramsing peterramsing deleted the adds-default-unit-to-fxflex-docs branch July 30, 2018 16:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants