This repository was archived by the owner on Jan 6, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 764
build: upgrade to Angular and CDK v14 #1409
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
354c282
build: upgrade to Angular and CDK v14
CaerusKaru e575025
build: switch to non-deprecated CircleCI images
CaerusKaru a801d98
build: remove deprecated jasmine matcher
CaerusKaru 1fd70a9
build: upgrade saucelabs tunnel
CaerusKaru 937fdb6
build: add CircleCI browser-tools orb
CaerusKaru 2bd14d2
build: revert dependency updates
CaerusKaru 0d845e5
build: adjust platform for grid tests using Blink
CaerusKaru 6038ec9
build: remove node12 from package.json
CaerusKaru 025dda0
build: remove browser-tools from test-browserstack
CaerusKaru d692406
build: remove browserstack tunnel handling
CaerusKaru bc47bc1
build: start browserstack tunnel in karma conf
CaerusKaru 31c3835
build: add pinned resolutions to package.json
CaerusKaru f6035b8
build: remove wait from browserscript runner
CaerusKaru 085b2ac
build: add sanity test
CaerusKaru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
# To validate changes, use an online parser, eg. | ||
# http://yaml-online-parser.appspot.com/ | ||
|
||
var_1: &docker_image circleci/node:14.16.1 | ||
var_1: &docker_image cimg/node:16.14.0 | ||
var_2: &cache_key v2-ng-layout-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.7.0 | ||
|
||
# Settings common to each job | ||
|
@@ -53,7 +53,7 @@ var_8: &docker-firefox-image | |
# TODO(devversion): Temporarily use a image that includes Firefox 62 because the | ||
# ngcontainer image does include an old Firefox version that does not support headless. | ||
# See the PR that fixes this: https://github.com/angular/angular/pull/26435 | ||
- image: circleci/node:14.16.1-browsers | ||
- image: cimg/node:16.14.0-browsers | ||
|
||
# Attaches the release output which has been stored in the workspace to the current job. | ||
# https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs | ||
|
@@ -64,7 +64,9 @@ var_9: &attach_release_output | |
# ----------------------------- | ||
# Container version of CircleCI | ||
# ----------------------------- | ||
version: 2 | ||
version: 2.1 | ||
orbs: | ||
browser-tools: circleci/[email protected] | ||
|
||
# ----------------------------------------------------------------------------------------- | ||
# Job definitions. Jobs which are defined just here, will not run automatically. Each job | ||
|
@@ -103,6 +105,7 @@ jobs: | |
steps: | ||
- *checkout_code | ||
- *attach_release_output | ||
- browser-tools/install-browser-tools | ||
- run: ./scripts/circleci/run-local-browser-tests.sh | ||
|
||
# ---------------------------------------------------------------------------- | ||
|
@@ -111,6 +114,7 @@ jobs: | |
# ---------------------------------------------------------------------------- | ||
tests_browserstack: | ||
<<: *job_defaults | ||
resource_class: xlarge | ||
environment: | ||
BROWSER_STACK_USERNAME: 'adamplumer1' | ||
BROWSER_STACK_ACCESS_KEY: 'WgLjxoB2zQ3tqmsznKnz' | ||
|
@@ -135,6 +139,7 @@ jobs: | |
steps: | ||
- *checkout_code | ||
- *attach_release_output | ||
- browser-tools/install-browser-tools | ||
|
||
- run: ./scripts/circleci/run-saucelabs-tests.sh | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -249,6 +249,5 @@ | |
} | ||
} | ||
} | ||
}, | ||
"defaultProject": "@angular/flex-layout" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting this request in the review comments. Can you use
^14.0.0 || ^15.0.0
for this, so delays like this in the future won't be blocking? Also, the engines declaration at the top shouldn't include 12.x node versions anymore, since v14 dropped support for 12.