-
Notifications
You must be signed in to change notification settings - Fork 767
[docs] Improve MediaChange documentation #598
Comments
The docs should call out explicitly that |
Added it to the Wiki here. Will add JSDoc in a follow-up PR. |
JSDoc PR: #920 |
Documentatation seems to be incorrect. It states that:
But:
|
It will in the next release, which should be out within the next couple weeks. If you use the nightly builds, the fix is already committed. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Docs request
What is the expected behavior?
MediaChange
properties should be JSDoc annotated. Additionally, the wiki page should clearly explain how to use theMediaChange
interface.What is the current behavior?
MediaChange
properties have no JSDoc documentation. TheObservableMedia
wiki page does not describe any of the properties ofMediaChange
.What are the steps to reproduce?
View
MediaChange src
andObservableMedia
wiki.What is the use-case or motivation for changing an existing behavior?
Developer ease of use/clarity
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?
My understanding is that the changes object doesn't actually contain helpful information other than
mqAlias
and usuallymedia.isActive()
should usually be used for logic checks.The text was updated successfully, but these errors were encountered: