fix(material/button): prevents mat-icon being cut off by text-spacing #30891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng vertically Updates Angular Components Button component specifically for .mat-icon buttons to add a min-height of min-content to avoid the icon from being cut off on the bottom when text-spacing is applied. Fixes b/250063405
Updates previous changes to Angular Components buttons containing icons and adds flex-shrink: 0; to prevent the sides from being cut off when text-spacing is applied or on smaller screens. Fixes b/411228600
essjay05
requested review from
adolgachev and
andrewseguin
and removed request for
a team
mmalerba
approved these changes
Apr 17, 2025
Adds comment to fix lint error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Button component specifically for .mat-icon buttons to add a min-height of min-content to avoid the icon from being cut off on the bottom when text-spacing is applied.
Fixes b/411228600
BEFORE screenshot
AFTER screenshot