build: update to latest next version and remove patch #30809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
Apr 5, 2025
crisbeto
commented
Apr 5, 2025
| @@ -185,9 +185,6 @@ | |||
| }, | |||
| "pnpm": { | |||
| "onlyBuiltDependencies": [], | |||
| "patchedDependencies": { | |||
There was a problem hiding this comment.
@devversion not sure if it's because I removed this, but it actually ends up breaking at runtime with the following error:
Error: The injectable '_PlatformLocation' needs to be compiled using the JIT compiler, but '@angular/compiler' is not available.
The injectable is part of a library that has been partially compiled.
However, the Angular Linker has not processed the library such that JIT compilation is used as fallback.
Ideally, the library is processed using the Angular Linker to become fully AOT compiled.
Alternatively, the JIT compiler should be loaded by bootstrapping using '@angular/platform-browser-dynamic' or '@angular/platform-server',
or manually provide the compiler with 'import "@angular/compiler";' before bootstrapping.
It looks like something isn't being compiled. I got this error from bazel test //src/universal-app:prerender_test, but the dev app breaks with something similar at runtime.
Updates the repo to the Angular 20.0.0-next.5 version which we need so we can move the `DOCUMENT` imports from `common` to `core`, and it allows us to remove a build patch because it includes angular/angular#60555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the repo to the Angular 20.0.0-next.5 version which we need so we can move the
DOCUMENTimports fromcommontocore, and it allows us to remove a build patch because it includes angular/angular#60555