Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/button): add missing tokens for hover, focus, and active pseudo-classes #30607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SocDario
Copy link

@SocDario SocDario commented Mar 8, 2025

Add missing tokens for overriding hover, focus, and active outlines, as well as the label styling of the outlined-button in Angular Material.

Fixes #30573

@SocDario SocDario requested a review from a team as a code owner March 8, 2025 14:34
@SocDario SocDario requested review from crisbeto and andrewseguin and removed request for a team March 8, 2025 14:34
Copy link

google-cla bot commented Mar 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: material/button labels Mar 8, 2025
…e pseudo-classes

Add missing tokens for overriding hover, focus, and active outlines,
as well as the label styling of the `outlined-button` in Angular Material.

Fixes angular#30573
@SocDario SocDario force-pushed the feat-add-missing-outlined-button-tokens branch from d114251 to fd34195 Compare March 8, 2025 15:03
@SocDario
Copy link
Author

SocDario commented Mar 8, 2025

@crisbeto
It looks like I missed some files.

  1. Could you clarify the difference between m2/mat and m2/mdc? Should I even add those tokens there?
  2. Do I need to specify the tokens in m3 styles as well?
  3. I ran the material.angular.io project locally, but I don't see those tokens in the Styling tab. Shouldn't the extract-tokens tool automatically pick them up?

I’d really appreciate your support with this implementation.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: material/button detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Button): Button hover/clickable outside border & missing token
1 participant