Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional typing of MatSelectChange #30324

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Optional typing of MatSelectChange #30324

merged 1 commit into from
Feb 19, 2025

Conversation

Wilt
Copy link
Contributor

@Wilt Wilt commented Jan 14, 2025

This event should be typed. Added type and fallback to any to make this optional and backwards compatible.

@Wilt Wilt requested a review from a team as a code owner January 14, 2025 13:44
@Wilt Wilt requested review from amysorto and mmalerba and removed request for a team January 14, 2025 13:44
Copy link

google-cla bot commented Jan 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mmalerba
Copy link
Contributor

@Wilt seems reasonable to me, can you sign the CLA? thanks!

@Wilt
Copy link
Contributor Author

Wilt commented Feb 12, 2025

@mmalerba I think I finally managed to get this CLA check to pass.

@Wilt
Copy link
Contributor Author

Wilt commented Feb 12, 2025

If this is viable for merging could you then also please merge similar optional typing solution for MatRadioChange event.
See another PR for that here: #30477

This event should be typed. Added type and fallback to any to make this optional and backwards compatible.
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 19, 2025
@mmalerba mmalerba removed the request for review from amysorto February 19, 2025 23:22
@mmalerba mmalerba merged commit dc8f98e into angular:main Feb 19, 2025
24 of 26 checks passed
@mmalerba
Copy link
Contributor

The changes were merged into the following branches: main, 19.1.x, 19.2.x

mmalerba pushed a commit that referenced this pull request Feb 19, 2025
This event should be typed. Added type and fallback to any to make this optional and backwards compatible.

(cherry picked from commit dc8f98e)
mmalerba pushed a commit that referenced this pull request Feb 19, 2025
This event should be typed. Added type and fallback to any to make this optional and backwards compatible.

(cherry picked from commit dc8f98e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/select target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants