Skip to content

api doc for directives #24135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

api doc for directives #24135

wants to merge 6 commits into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mary-poppins
Copy link

You can preview 29ddcf8 at https://pr24135-29ddcf8.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from 29ddcf8 to 62cbb1d Compare June 13, 2018 19:37
@mary-poppins
Copy link

You can preview 62cbb1d at https://pr24135-62cbb1d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ea6598d at https://pr24135-ea6598d.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from ea6598d to 1a7e488 Compare June 28, 2018 18:05
@mary-poppins
Copy link

You can preview 1a7e488 at https://pr24135-1a7e488.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from 1a7e488 to e5cdb0f Compare July 4, 2018 16:13
@mary-poppins
Copy link

You can preview e5cdb0f at https://pr24135-e5cdb0f.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from e5cdb0f to b29b47f Compare July 9, 2018 16:11
@mary-poppins
Copy link

You can preview b29b47f at https://pr24135-b29b47f.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from b29b47f to c8cc271 Compare July 13, 2018 15:29
@mary-poppins
Copy link

You can preview c8cc271 at https://pr24135-c8cc271.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4e9ef50 at https://pr24135-4e9ef50.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from 4e9ef50 to 3699efd Compare July 16, 2018 16:18
@mary-poppins
Copy link

You can preview 3699efd at https://pr24135-3699efd.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from 3699efd to 98b3203 Compare July 17, 2018 16:11
@mary-poppins
Copy link

You can preview 98b3203 at https://pr24135-98b3203.ngbuilds.io/.

trotyl
trotyl reviewed Jul 18, 2018
View reviewed changes
packages/common/src/directives/ng_switch.ts Outdated
* Within that container, `[ngSwitchCase]` directives on views
* provide the match expressions.
* - First view that matches is added to the DOM. The same view can be associated with
* more than one case.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How? AFAIK this is a pending feature request: #14659.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from 98b3203 to 11963ca Compare July 31, 2018 16:18
@mary-poppins
Copy link

You can preview 11963ca at https://pr24135-11963ca.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from 11963ca to d2ef512 Compare August 3, 2018 17:35
@mary-poppins
Copy link

You can preview d2ef512 at https://pr24135-d2ef512.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-apidoc-directive branch from d2ef512 to c8045e1 Compare August 6, 2018 16:31
@mary-poppins
Copy link

You can preview c8045e1 at https://pr24135-c8045e1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 3bcde99 at https://pr24135-3bcde99.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a1e7273 at https://pr24135-a1e7273.ngbuilds.io/.

@jenniferfell jenniferfell added risk: low area: common Issues related to APIs in the @angular/common package area: core Issues related to the framework runtime labels Nov 15, 2018
@mary-poppins
Copy link

You can preview 3583dbb at https://pr24135-3583dbb.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 19d7af5 at https://pr24135-19d7af5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview fb33966 at https://pr24135-fb33966.ngbuilds.io/.

@mary-poppins
Copy link

You can preview eaa716c at https://pr24135-eaa716c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ef08c0d at https://pr24135-ef08c0d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e9678c6 at https://pr24135-e9678c6.ngbuilds.io/.

petebacondarwin
petebacondarwin reviewed Nov 30, 2018
View reviewed changes
packages/common/src/directives/ng_style.ts
* - A value is an expression to be evaluated.
*
* An attribute directive that updates styles for the containing HTML element.
* Sets one or more style propeties, specified as key-value pairs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: properties

@mary-poppins
Copy link

You can preview 1e1507b at https://pr24135-1e1507b.ngbuilds.io/.

@jbogarthyde
Copy link
Contributor Author

Broken up into individual PRs for each file:
#27376
#27377
#27378
#27379
#27380
#27381

@jbogarthyde jbogarthyde deleted the jb-apidoc-directive branch December 4, 2018 16:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@trotyl trotyl trotyl left review comments

@jenniferfell jenniferfell jenniferfell requested changes

@IgorMinar IgorMinar IgorMinar requested changes

@mhevery mhevery Awaiting requested review from mhevery

Assignees

@IgorMinar IgorMinar

Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package area: core Issues related to the framework runtime cla: yes effort3: weeks risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jbogarthyde @mary-poppins @jenniferfell @petebacondarwin @IgorMinar @trotyl @googlebot