Conversation
Updated the level to an enum for better readability and initiated the update instructions to v15.
There was a problem hiding this comment.
Maybe move this one third? What is the reason you added it to the end?
There was a problem hiding this comment.
I ordered them this way to appear as a checklist in which, if all looked good, you'd update your application.
Because you can't un-update an application, this seemed the safest order to prevent:
- read
- update
- read further and facepalm
There was a problem hiding this comment.
I'd recommend moving ng update first because some of these changes are not available in v14 which will cause errors when folks make the changes we suggest here.
There was a problem hiding this comment.
That makes sense. Thanks!
There was a problem hiding this comment.
I'd suggest updating to:
| { possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Basic, step: 'v15 keyframe', action: 'In v15, `@keyframes` names are prefixed with the component\'s <emphasis>scope name</emphasis>. <a href="https://angular.io/guide/update-to-version-15#v15-bc-03" alt="Link to more information about this change">Read further</a>' }, | |
| { possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Basic, step: 'v15 keyframe', action: 'The Angular compiler now prefixes `@keyframes` in CSS with components' scope. This means that TypeScript code that relies keyframe names now will no longer work. Recommended update is to define keyframes programmatically, use global stylesheets, or change component's view encapsulation. <a href="https://angular.io/guide/update-to-version-15#v15-bc-03" alt="Link to more information about this change">Read further</a>' }, |
There was a problem hiding this comment.
Updated in current commit
There was a problem hiding this comment.
| { possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Basic, step: '', action: 'In v15, when a class inherits its constructor from a base class, the compiler can report an error when that constructor cannot be used for dependency injection purposes. <a href="https://angular.io/guide/update-to-version-15#v15-bc-05" alt="Link to more information about this change">Read further</a>'}, | |
| { possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Medium, step: '', action: 'Make sure you use decorators in base classes when their child classes inherit constructors and use dependency injection. Base classes should be decorated with `@Injectable` or `@Directive` alternatively the compiler will throw an error. <a href="https://angular.io/guide/update-to-version-15#v15-bc-05" alt="Link to more information about this change">Read further</a>'}, |
There was a problem hiding this comment.
for:
Base classes should be decorated with @Injectableor@directive alternatively the compiler will throw an error.
would this work?
Base classes should be decorated with either @Injectableor@directive or the compiler returns an error.
There was a problem hiding this comment.
Yes, this sounds good. @Directive should be uppercase, just like @Injectable.
There was a problem hiding this comment.
Updated in latest commit.
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
Let us tell developers what to do about a deprecation rather than repeat what we've changed.
There was a problem hiding this comment.
We can recommend people to review their application to prevent visual breakages.
There was a problem hiding this comment.
Added in latest commit.
There was a problem hiding this comment.
I'll move this to the top as well.
There was a problem hiding this comment.
Added in latest commit.
There was a problem hiding this comment.
I'll change this from basic to medium.
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
I'll change this from basic to medium.
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
I'll change this from basic to medium.
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
I'll change this from basic to advanced.
Can we tell people what they need to do and after share why they need to make a change?
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
That's definitely advanced, not basic.
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
Can we say: "If your tests with RouterOutlet break, make sure you don't depend on the instantiation order of the corresponding component relative to change detection execution. As of v15 now..."
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
Can we say what's the alternative of canParse?
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
setDisabledState is medium/advanced.
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
Can we say what's the action item for developers?
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
Updated in latest commit.
There was a problem hiding this comment.
Updated in latest commit.
Co-Authored-By: Minko Gechev <mgechev@gmail.com>
Co-Authored-By: Minko Gechev <mgechev@gmail.com>
|
@mgechev I've updated this to address your feedback. |
2 participants
Updates the text to include the guide to update from v14 to v15.
Also includes minor UI text edits.