V15 update #205

bob-watson · 2022-11-02T23:57:40Z

Updates the text to include the guide to update from v14 to v15.
Also includes minor UI text edits.

Updated the level to an enum for better readability and initiated the update instructions to v15.

src/app/app.component.ts

mgechev · 2022-11-03T21:22:25Z

src/app/recommendations.ts

Maybe move this one third? What is the reason you added it to the end?

I ordered them this way to appear as a checklist in which, if all looked good, you'd update your application.
Because you can't un-update an application, this seemed the safest order to prevent:

read

update

read further and facepalm

I'd recommend moving ng update first because some of these changes are not available in v14 which will cause errors when folks make the changes we suggest here.

That makes sense. Thanks!

src/app/recommendations.ts

mgechev · 2022-11-03T21:24:26Z

src/app/recommendations.ts

I'd suggest updating to:

Suggested change

{ possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Basic, step: 'v15 keyframe', action: 'In v15, `@keyframes` names are prefixed with the component\'s <emphasis>scope name</emphasis>. <a href="https://angular.io/guide/update-to-version-15#v15-bc-03" alt="Link to more information about this change">Read further</a>' },

{ possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Basic, step: 'v15 keyframe', action: 'The Angular compiler now prefixes `@keyframes` in CSS with components' scope. This means that TypeScript code that relies keyframe names now will no longer work. Recommended update is to define keyframes programmatically, use global stylesheets, or change component's view encapsulation. <a href="https://angular.io/guide/update-to-version-15#v15-bc-03" alt="Link to more information about this change">Read further</a>' },

Updated in current commit

mgechev · 2022-11-03T21:31:07Z

src/app/recommendations.ts

Suggested change

{ possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Basic, step: '', action: 'In v15, when a class inherits its constructor from a base class, the compiler can report an error when that constructor cannot be used for dependency injection purposes. <a href="https://angular.io/guide/update-to-version-15#v15-bc-05" alt="Link to more information about this change">Read further</a>'},

{ possibleIn: 1500, necessaryAsOf: 1500, level: ApplicationComplexity.Medium, step: '', action: 'Make sure you use decorators in base classes when their child classes inherit constructors and use dependency injection. Base classes should be decorated with `@Injectable` or `@Directive` alternatively the compiler will throw an error. <a href="https://angular.io/guide/update-to-version-15#v15-bc-05" alt="Link to more information about this change">Read further</a>'},

for:
Base classes should be decorated with @Injectableor@directive alternatively the compiler will throw an error.
would this work?
Base classes should be decorated with either @Injectableor@directive or the compiler returns an error.

Yes, this sounds good. @Directive should be uppercase, just like @Injectable.

Updated in latest commit.

mgechev

Let us tell developers what to do about a deprecation rather than repeat what we've changed.

mgechev · 2022-11-08T00:58:22Z

src/app/recommendations.ts

We can recommend people to review their application to prevent visual breakages.

Added in latest commit.

mgechev · 2022-11-08T00:58:35Z

src/app/recommendations.ts

I'll move this to the top as well.

Added in latest commit.

mgechev · 2022-11-08T00:59:08Z

src/app/recommendations.ts

I'll change this from basic to medium.

Updated in latest commit.

mgechev · 2022-11-08T00:59:16Z

src/app/recommendations.ts

I'll change this from basic to medium.

Updated in latest commit.

mgechev · 2022-11-08T00:59:21Z

src/app/recommendations.ts

I'll change this from basic to medium.

Updated in latest commit.

mgechev · 2022-11-08T00:59:59Z

src/app/recommendations.ts

I'll change this from basic to advanced.

Can we tell people what they need to do and after share why they need to make a change?

Updated in latest commit.

mgechev · 2022-11-08T01:01:09Z

src/app/recommendations.ts

That's definitely advanced, not basic.

Updated in latest commit.

mgechev · 2022-11-08T01:02:07Z

src/app/recommendations.ts

Can we say: "If your tests with RouterOutlet break, make sure you don't depend on the instantiation order of the corresponding component relative to change detection execution. As of v15 now..."

Updated in latest commit.

mgechev · 2022-11-08T01:02:23Z

src/app/recommendations.ts

That's advanced.

Updated in latest commit.

mgechev · 2022-11-08T01:02:32Z

src/app/recommendations.ts

Can we say what's the alternative of canParse?

Updated in latest commit.

mgechev · 2022-11-08T01:02:51Z

src/app/recommendations.ts

setDisabledState is medium/advanced.

Updated in latest commit.

mgechev · 2022-11-08T01:03:02Z

src/app/recommendations.ts

Can we say what's the action item for developers?

Updated in latest commit.

mgechev · 2022-11-08T01:03:23Z

src/app/recommendations.ts

Missing step name.

Updated in latest commit.

mgechev · 2022-11-08T01:03:36Z

src/app/recommendations.ts

I'd say this is medium.

Updated in latest commit.

mgechev

Left a few more comments.

Co-Authored-By: Minko Gechev <[email protected]>

bob-watson · 2022-11-08T21:35:47Z

@mgechev I've updated this to address your feedback.

Initial instructions for v15 and refactoring

34a9e50

Updated the level to an enum for better readability and initiated the update instructions to v15.

mgechev reviewed Nov 3, 2022

View reviewed changes

src/app/app.component.ts Outdated Show resolved Hide resolved

mgechev reviewed Nov 3, 2022

View reviewed changes

src/app/recommendations.ts Outdated Show resolved Hide resolved

mgechev reviewed Nov 3, 2022

View reviewed changes

mgechev suggested changes Nov 3, 2022

View reviewed changes

mgechev reviewed Nov 8, 2022

View reviewed changes

mgechev suggested changes Nov 8, 2022

View reviewed changes

Bob Watson and others added 2 commits November 8, 2022 13:33

UI text tweaks for v15 update

bb7f339

Co-Authored-By: Minko Gechev <[email protected]>

Add v15 update instructions

57ce936

Co-Authored-By: Minko Gechev <[email protected]>

bob-watson marked this pull request as ready for review November 8, 2022 21:35

bob-watson marked this pull request as draft November 8, 2022 21:41

bob-watson marked this pull request as ready for review November 8, 2022 21:42

mgechev approved these changes Nov 9, 2022

View reviewed changes

mgechev merged commit 9a1bf81 into angular:main Nov 9, 2022

V15 update #205

V15 update #205

Uh oh!

Conversation

bob-watson commented Nov 2, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mgechev Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgechev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bob-watson Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bob-watson Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgechev Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

mgechev Nov 3, 2022 •

edited

Loading

bob-watson Nov 8, 2022 •

edited

Loading

bob-watson Nov 8, 2022 •

edited

Loading

mgechev Nov 8, 2022 •

edited

Loading