-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@angular/cli): add initial set of signal form examples #31134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
clydin
wants to merge
5
commits into
angular:main
Choose a base branch
from
clydin:mcp/signal-form-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93f4632 to
0c84e42
Compare
dd1d83d to
3653ee5
Compare
3653ee5 to
190a3a0
Compare
packages/angular/cli/lib/examples/signal-forms/15-accessible-styled-forms.md
Outdated
Show resolved
Hide resolved
packages/angular/cli/lib/examples/signal-forms/15-accessible-styled-forms.md
Outdated
Show resolved
Hide resolved
packages/angular/cli/lib/examples/signal-forms/15-accessible-styled-forms.md
Outdated
Show resolved
Hide resolved
packages/angular/cli/lib/examples/signal-forms/15-accessible-styled-forms.md
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Sep 14, 2025
| type="text" | ||
| [control]="registrationForm.name" | ||
| [class.invalid]="registrationForm.name().invalid() && registrationForm.name().touched()" | ||
| [attr.aria-invalid]="registrationForm.name().invalid()" |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one will be supported once angular/angular#63748 gets in and is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[attr.aria-invalid] is working right?
[aria-invalid] was not.
packages/angular/cli/lib/examples/signal-forms/03-cross-field-validation.md
Outdated
Show resolved
Hide resolved
packages/angular/cli/lib/examples/signal-forms/03-cross-field-validation.md
Outdated
Show resolved
Hide resolved
packages/angular/cli/lib/examples/signal-forms/15-accessible-styled-forms.md
Show resolved
Hide resolved
packages/angular/cli/lib/examples/signal-forms/02-built-in-validators.md
Outdated
Show resolved
Hide resolved
190a3a0 to
e38896f
Compare
packages/angular/cli/lib/examples/signal-forms/03-cross-field-validation.md
Outdated
Show resolved
Hide resolved
This commit introduces a comprehensive set of 18 examples for the new signal-based forms functionality in Angular. These examples are designed to be used with the `find_examples` tool (MCP) to provide developers with actionable, real-world code snippets covering a wide range of use cases. The `find_examples` tool is currently experimental and must be enabled using the `-E find_examples` option when running the `ng mcp` command. The examples cover the following key concepts: - Core concepts and basic setup - Built-in and cross-field validation - Dynamic and conditional form structures - Custom form controls and reusable validators - Asynchronous operations and third-party integrations (Zod) - Best practices for testing, accessibility, and styling
e38896f to
40f080a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: @angular/cli
detected: feature
PR contains a feature commit
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a comprehensive set of 18 examples for the new signal-based forms functionality in Angular. These examples are designed to be used with the
find_examplestool (MCP) to provide developers with actionable, real-world code snippets covering a wide range of use cases.The
find_examplestool is currently experimental and must be enabled using the-E find_examplesoption when running theng mcpcommand.The examples cover the following key concepts: