Skip to content

refactor(@angular/cli): add a get best practices guide MCP tool #30725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 16, 2025

The Angular CLI's stdio-based MCP server now contains a tool to get an Angular best practices guide. This is in addition to a resource with the same content. The tool provides a description that strongly encourages the use of this tool and its content when performing Angular related tasks. This is useful in cases where MCP resource usage is not available or the resource would need to manually be added as context for specific use cases.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Jul 16, 2025
@clydin clydin force-pushed the mcp/get-best-practices branch from ab2f994 to e170b0e Compare July 16, 2025 23:06
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall but I think we can skip the await?

@jkrems jkrems added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 17, 2025
@geromegrignon
Copy link
Contributor

The Angular CLI's stdio-based MCP server now contains a tool to get an Angular best practices guide. This is in addition to a resource with the same content. The tool provides a description that strongly encourages the use of this tool and its content when performing Angular related tasks. This is useful in cases where MCP resource usage is not available or the resource would need to manually be added as context for specific use cases.

If the MCP resource usage refers to the compatibility matrix(https://modelcontextprotocol.io/clients#feature-support-matrix), from my attemps at doing about the same with Cursor, a content with type: "resource" exposed by a tool is still considered as a resource, resulting in a Content type "resource" not supported message

The Angular CLI's stdio-based MCP server now contains a tool to get an
Angular best practices guide. This is in addition to a resource with the
same content. The tool provides a description that strongly encourages
the use of this tool and its content when performing Angular related tasks.
This is useful in cases where MCP resource usage is not available or the
resource would need to manually be added as context for specific use cases.
@clydin clydin force-pushed the mcp/get-best-practices branch from e170b0e to 557d6f1 Compare July 17, 2025 16:52
@clydin clydin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 17, 2025
@clydin
Copy link
Member Author

clydin commented Jul 17, 2025

If the MCP resource usage refers to the compatibility matrix(https://modelcontextprotocol.io/clients#feature-support-matrix), from my attemps at doing about the same with Cursor, a content with type: "resource" exposed by a tool is still considered as a resource, resulting in a Content type "resource" not supported message

It was referring to UI mechanisms to add resources as context. However, to be safe the content is now text.

@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Jul 17, 2025
@clydin clydin merged commit 3cd73d3 into angular:main Jul 18, 2025
31 checks passed
@clydin
Copy link
Member Author

clydin commented Jul 18, 2025

The changes were merged into the following branches: main, 20.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/cli target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants