Skip to content

build: update dependency webpack-dev-server to v5.2.2 #30487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

build: update dependency webpack-dev-server to v5.2.2 #30487

merged 2 commits into from
Jun 10, 2025

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Jun 6, 2025

@dgp1130 dgp1130 requested a review from alan-agius4 June 6, 2025 17:20
@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer target: lts This PR is targeting a version currently in long-term support labels Jun 6, 2025
@dgp1130 dgp1130 marked this pull request as ready for review June 6, 2025 17:20
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 6, 2025
@dgp1130 dgp1130 mentioned this pull request Jun 6, 2025
Merged
13 tasks
@angular-robot angular-robot bot requested a review from alan-agius4 June 6, 2025 18:46
@dgp1130 dgp1130 requested a review from josephperrott June 6, 2025 23:34
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Jun 6, 2025

This seems to be encountering the same @angular/localize Node version issue as the v19 version and also a separate unit test running issue where Bazel either cancels itself or the browser fails to load properly.

This seems unlikely to cause a breakage, so maybe we just merge through it? 🤞

@alan-agius4 alan-agius4 linked an issue Jun 10, 2025 that may be closed by this pull request
CVE-2025-30360, CVE-2025-30359 webpack-dev-server users' source code may be stolen when they access a malicious web site #30505
Closed
1 task
alan-agius4
alan-agius4 reviewed Jun 10, 2025
View reviewed changes
dgp1130 added 2 commits June 10, 2025 12:04
@dgp1130
build: disable RBE
39412e3 
For security reasons, RBE was made more restrictive and broke the current v18 configuration.
@dgp1130
build: update dependency webpack-dev-server to v5.2.2
642effa 
v18 port of [`b120e1411c28c99defb34274a11f0fb54972178a`](angular#30469).
@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 10, 2025
josephperrott
josephperrott approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin merged commit f048078 into angular:18.2.x Jun 10, 2025
27 of 30 checks passed
@alan-agius4 alan-agius4 mentioned this pull request Jun 11, 2025
Closed
1 task
@dgp1130 dgp1130 deleted the webpack-bump branch June 11, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2025-30360, CVE-2025-30359 webpack-dev-server users' source code may be stolen when they access a malicious web site
4 participants
@dgp1130 @josephperrott @alan-agius4 @clydin