This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Issue 994: Change guard against closing the Select when in a multisel… #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 4, 2015 16:26
…ect with close-on-select(false) to prevent failing to close when mixing interaction between keyboard and mouse.
…l in multiselect uis:select handler
…iin a single 'paste' while tagging.
| // The model should be updated so that selected items may be removed, however | ||
| // this should be done after the onDocumentClick handler has run so that the | ||
| // item's list item is still in the DOM. | ||
| $timeout(function () { |
There was a problem hiding this comment.
This seems fragile - why is this necessary?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect with close-on-select(false) to prevent failing to close when mixing interaction between keyboard and mouse.
Changes are proposed to fix the issue detailed in Issue 994