Feat/#23 support default values in route data classes #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default value handling
…deep link parameters more robustly
…on to api for better transitive visibility
angryPodo
added
the
FEAT✨
angryPodo
deleted the
feat/#23-support-default-values-in-route-data-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored RouteFactoryGenerator to handle parameter parsing using kotlinx.serialization.
Previously, missing parameters would cause crashes or pass nulls even if a default value was defined. Now, we construct a JsonObject from the parameter map and let Json.decodeFromJsonElement handle the object creation. This
ensures Kotlin default values work as expected.
Also updated wisp-runtime to expose kotlinx-serialization-json via api so consumer modules don't need to add the dependency manually to compile the generated code.