Refactor/#19 전체 프로젝트 구조 및 코드 품질 개선 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a comprehensive refactoring of the library modules (wisp-processor, wisp-runtime) to improve code quality, maintainability, and organization. - **Package Structure:** Reorganized files into role-based sub-packages (processor, validation, util, parser, matcher, spi). - **Code Readability:** Refactored key files for clarity, simplicity, and thread-safety. - **Code Style:** Fixed all ktlint violations across the library modules. - **Test & Core Cleanup:** Fixed compile errors in tests and removed obsolete/dead code.
Improves the sample app to be a more realistic and useful example for the library. - **Splash Screen Flow:** Adds a new Splash screen as the app's entry point, which simulates a loading delay and handles the initial navigation. This provides a realistic use case for token validation or data fetching. - **External Deep Link:** The app now handles incoming deep link URIs from the intent, allowing it to be launched into a specific state from an external source. - **Package Structure:** Reorganizes the app module's packages by feature for better clarity.
angryPodo
added
the
REFACTOR🧽
jm991014
approved these changes
Nov 25, 2025
Collaborator
jm991014
left a comment
jm991014
left a comment
There was a problem hiding this comment.
패키지 구조가 직관적으로 개선되어 보기 좋네요!!
별다른 수정 사항 없어 보입니다. 머지하시죠! 🚀🚀🚀
| val declaration = resolvedType.declaration | ||
| val isEnum = | ||
| declaration is KSClassDeclaration && declaration.classKind == ClassKind.ENUM_CLASS | ||
| (resolvedType.declaration as? KSClassDeclaration)?.classKind == ClassKind.ENUM_CLASS |
| private var instance: Wisp? = null | ||
|
|
||
| @JvmStatic | ||
| @Synchronized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
라이브러리 및 샘플 앱의 전반적인 코드 품질, 가독성, 패키지 구조를 개선합니다.
라이브러리 모듈 (
wisp-processor,wisp-runtime)ktlint위반 사항을 모두 수정하고, 코드 가독성을 개선했습니다. (함수 추출, 스레드 안전성 확보 등)샘플 앱 (
app)Intent)를 처리하고, 비동기 작업을 시뮬레이션하는Splash화면을 도입하여 더 현실적인 예제로 개선했습니다.app모듈의 패키지 구조를 기능(navigation,ui.main)에 맞게 정리했습니다.