Skip to content

Conversation

@lemaitre-aneo
Copy link
Contributor

Motivation

[Include the reason behind these changes and any relevant context.]

Description

[Provide a detailled explanation of the modifications you have made. Link any related issues.]

Testing

[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]

Additional Information

[Any additional information that reviewers should be aware of.]

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@aneojgurhem aneojgurhem requested a review from Copilot March 26, 2025 22:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modularizes Helm charts for Armonik by adding a new library chart and updating maintainer contact information.

  • Added the "armonik-common" library chart with its metadata file.
  • Updated the maintainer email in the ActiveMQ chart to ensure consistency across charts.
  • Updated the ActiveMQ README.md to reflect the new email address.

Reviewed Changes

Copilot reviewed 83 out of 84 changed files in this pull request and generated no comments.

File Description
charts/armonik-common/Chart.yaml Introduces new library chart metadata.
charts/activemq/Chart.yaml Updates maintainer email information.
charts/activemq/README.md Reflects the updated maintainer email.
Files not reviewed (1)
  • charts/armonik-common/templates/_conf_materialize.tpl: Language not supported

@lemaitre-aneo lemaitre-aneo force-pushed the fl/revamp-helm branch 2 times, most recently from 658f31a to fe7ffc4 Compare March 27, 2025 23:10
@CLAassistant
Copy link

CLAassistant commented May 28, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ lemaitre-aneo
❌ aneo-ssam
❌ viktoraneo
You have signed the CLA already but the status is still pending? Let us recheck it.

@lemaitre-aneo lemaitre-aneo force-pushed the fl/revamp-helm branch 2 times, most recently from 9fce8b5 to 19c2461 Compare September 24, 2025 23:09
@lemaitre-aneo lemaitre-aneo force-pushed the fl/revamp-helm branch 2 times, most recently from 9002a73 to a88879c Compare September 30, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants