-
Notifications
You must be signed in to change notification settings - Fork 7
feat: modular Helm charts #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modularizes Helm charts for Armonik by adding a new library chart and updating maintainer contact information.
- Added the "armonik-common" library chart with its metadata file.
- Updated the maintainer email in the ActiveMQ chart to ensure consistency across charts.
- Updated the ActiveMQ README.md to reflect the new email address.
Reviewed Changes
Copilot reviewed 83 out of 84 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/armonik-common/Chart.yaml | Introduces new library chart metadata. |
| charts/activemq/Chart.yaml | Updates maintainer email information. |
| charts/activemq/README.md | Reflects the updated maintainer email. |
Files not reviewed (1)
- charts/armonik-common/templates/_conf_materialize.tpl: Language not supported
658f31a to
fe7ffc4
Compare
eac58a2 to
6679e21
Compare
|
|
505f2b5 to
070f1f3
Compare
9fce8b5 to
19c2461
Compare
19c2461 to
b0ab47c
Compare
cdacef2 to
532583f
Compare
9002a73 to
a88879c
Compare
a88879c to
cb4a9fe
Compare
Motivation
[Include the reason behind these changes and any relevant context.]
Description
[Provide a detailled explanation of the modifications you have made. Link any related issues.]
Testing
[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]
Impact
[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]
Additional Information
[Any additional information that reviewers should be aware of.]
Checklist