refactor: Start deep refactor of the client part of the project. #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkirschenmann
force-pushed
the
WK-clean
branch
5 times, most recently
from
eb9c702 to
97039b2
Compare
wkirschenmann
force-pushed
the
WK-clean
branch
from
97039b2 to
9d58564
Compare
Contributor
|
For the changes visible to the user, we need to document extensively all the name changes and api changes. Will be very important to create a proper changelog |
| /// </summary> | ||
| [PublicAPI] | ||
| public enum ArmonikStatusCode | ||
| public enum ArmonikTaskStatusCode |
Contributor
There was a problem hiding this comment.
Suggested change
| public enum ArmonikTaskStatusCode | |
| public enum ArmoniKTaskStatusCode |
aneojgurhem
reviewed
Aug 23, 2023
wkirschenmann
force-pushed
the
WK-clean
branch
from
26cf28d to
fdb98a7
Compare
wkirschenmann
force-pushed
the
WK-clean
branch
from
fdb98a7 to
f694288
Compare
But still using new ApiExt methods.
wkirschenmann
force-pushed
the
WK-clean
branch
from
729f640 to
685d2e9
Compare
aneojgurhem
reviewed
Aug 25, 2023
...ToEndTests/ArmoniK.EndToEndTests.Client/Tests/AggregationPriority/AggregationPriorityTest.cs
Outdated
Show resolved
Hide resolved
aneojgurhem
reviewed
Aug 28, 2023
| var taskRawData = new List<TaskDetailed>(); | ||
|
|
||
| await foreach (var taskRaw in RetrieveAllTasksStats(service.GetChannel(), | ||
| await foreach (var taskRaw in RetrieveAllTasksStats(null, |
aneojgurhem
reviewed
Aug 28, 2023
| if (e.StatusCode == ArmonikStatusCode.TaskCancelled) | ||
| if (e.TaskStatusCode == ArmonikTaskStatusCode.TaskCancelled) | ||
| { | ||
| Log.LogWarning($"Task canceled : {taskId}. Status {e.StatusCode.ToString()} Message : {e.Message}\nDetails : {e.OutputDetails}"); |
Contributor
There was a problem hiding this comment.
.ToString may not be needed anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin of work.
Submitter.SubmitterClient