feat: Draft: Session status notification stream impl#1110
Draft
plpn90 wants to merge 4 commits intoaneoconsulting:mainfrom
Draft
feat: Draft: Session status notification stream impl#1110plpn90 wants to merge 4 commits intoaneoconsulting:mainfrom
plpn90 wants to merge 4 commits intoaneoconsulting:mainfrom
Conversation
|
Phil Pohlmann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
plpn90
commented
Dec 2, 2025
| SessionUpdateType.Update), | ||
| ChangeStreamOperationType.Delete => | ||
| new SessionUpdate( | ||
| document.DocumentKey.First().Value.AsString, // hmm.. :( |
Author
There was a problem hiding this comment.
Created the draft as i especially am unsure with this line. Has anyone an idea what is the better way to collect the SessionId before the document is deleted? This case works only because the SessionId is also the document-key, but obviously this might change.
Contributor
|
Waiting for aneoconsulting/ArmoniK.Api#650 before reviewing as it will change and this PR will be updated too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// DRAFT!
Motivation
// as in combination with ArmoniK.Api #650
Description
Session status notitification stream implementation for the
EventsServiceTesting
Tested locally with our system locally with k3s
No Unit/Integrations tests so far
Impact
[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]
Additional Information
[Any additional information that reviewers should be aware of.]
Checklist