Skip to content

feat: Draft: Session status notification stream impl#1110

Draft
plpn90 wants to merge 4 commits intoaneoconsulting:mainfrom
plpn90:dev/impl-session-stream
Draft

feat: Draft: Session status notification stream impl#1110
plpn90 wants to merge 4 commits intoaneoconsulting:mainfrom
plpn90:dev/impl-session-stream

Conversation

@plpn90
Copy link
Copy Markdown

@plpn90 plpn90 commented Dec 2, 2025

// DRAFT!

Motivation

// as in combination with ArmoniK.Api #650

Description

Session status notitification stream implementation for the EventsService

Testing

Tested locally with our system locally with k3s
No Unit/Integrations tests so far

Impact

[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]

Additional Information

[Any additional information that reviewers should be aware of.]

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • [x ] I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • [x ] I have assessed the performance impact of my modifications.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Phil Pohlmann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

SessionUpdateType.Update),
ChangeStreamOperationType.Delete =>
new SessionUpdate(
document.DocumentKey.First().Value.AsString, // hmm.. :(
Copy link
Copy Markdown
Author

@plpn90 plpn90 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created the draft as i especially am unsure with this line. Has anyone an idea what is the better way to collect the SessionId before the document is deleted? This case works only because the SessionId is also the document-key, but obviously this might change.

@plpn90 plpn90 changed the title Draft: Dev/impl session stream feat: Draft: Dev/impl session stream Dec 2, 2025
@plpn90 plpn90 changed the title feat: Draft: Dev/impl session stream feat: Draft: Session status notification stream Dec 2, 2025
@plpn90 plpn90 changed the title feat: Draft: Session status notification stream feat: Draft: Session status notification stream impl Dec 2, 2025
@aneojgurhem
Copy link
Copy Markdown
Contributor

Waiting for aneoconsulting/ArmoniK.Api#650 before reviewing as it will change and this PR will be updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants